Skip to content

Conversation

@EricBCoding
Copy link
Contributor

@EricBCoding EricBCoding commented Apr 25, 2025

Hi,

I introduced a few quality of life improvements to the OptimalSteps scheduler node from #7584 :

  • Reduced the minimum value of steps from 3 to 1: there are times when you may want to run inference with only 1-2 steps, such as 2-step upscaling @ 50% denoise.
  • Added an SDXL preset to the NOISE_LEVELS dictionary: the values here are derived from the AYS scheduler and seem to work pretty well.
  • Added custom_sigmas optional input: the log-linear interpolation included with this node may prove useful for other models, especially if you can pass in your own sigma values. Supplying a comma-separated string will override the included presets (SDXL, WAN, Flux).

@henrikvilhelmberglund
Copy link

Is 0.0 correct? This gives a black image for me, changing it to 0.001 like the others fixed it but not sure what the correct value should be.

@EricBCoding
Copy link
Contributor Author

EricBCoding commented Apr 27, 2025

Oh, good call. It should probably end with 0.001 for better compatibility across samplers. Thank you, @henrikvilhelmberglund !

@comfy-pr-bot
Copy link
Member

Test Evidence Check

⚠️ Warning: Test Explanation Missing

If this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.

You can add it by:

  • GitHub: Drag & drop media directly into the PR description
  • YouTube: Include a link to a short demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants